[Java] Refine tests and fix single-process mode#4265
[Java] Refine tests and fix single-process mode#4265raulchen merged 18 commits intoray-project:masterfrom
Conversation
raulchen
changed the title
|
Test FAILed. |
raulchen
changed the title
|
Test FAILed. |
There was a problem hiding this comment.
Also log the current mode in this log?
==== Running test: A.b [Cluster]
There was a problem hiding this comment.
probably not very useful. we can also find the mode from the command.
|
Test FAILed. |
|
Test FAILed. |
raulchen
force-pushed
the
fix_single_process
branch
from
25c5aa0 to
715e135
Compare
|
Test FAILed. |
guoyuhong
left a comment
guoyuhong
left a comment
There was a problem hiding this comment.
LGTM. I left a question.
java/test.sh
Outdated
| # Skip compiling the binaries if `--skip-compile` is passed in. | ||
| if [[ "$@" != *--skip-compile* ]]; then | ||
| echo "Compiling binaries." | ||
| $ROOT_DIR/../build.sh -l python,java |
There was a problem hiding this comment.
This line seems not to install python ray (just build) and which ray may still be missing.
There was a problem hiding this comment.
I added ./ci/travis/install-ray.sh in the java job, which will install ray. However these 2 commands will do build.sh twice. I'll merge them in the next PR.
There was a problem hiding this comment.
nvm, fixed in this PR.
|
Test FAILed. |
|
Test FAILed. |
|
Test FAILed. |
|
Test FAILed. |
|
Test FAILed. |
|
Test FAILed. |
|
Test FAILed. |
4 participants
What do these changes do?
SkipExceptioncannot be thrown fromsetUp, otherwise all remaining tests will be skipped. We didn't catch a bug because of this.MultiLanguageClusterTestisn't actually running in Travis.Related issue number